Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form validation doesn't check for validity #7

Open
JoshKamps opened this issue Nov 23, 2023 · 0 comments
Open

Form validation doesn't check for validity #7

JoshKamps opened this issue Nov 23, 2023 · 0 comments

Comments

@JoshKamps
Copy link

JoshKamps commented Nov 23, 2023

Hello, was just following along with the tutorial when I noticed I could still submit a non-alphanumeric username. Should this not be like so:

{#if isAvailable && isValid} <button class="btn btn-success">Confirm username @{username} </button> {/if}

or am I missing something?

https://github.com/fireship-io/fkit-course/blob/ce1b40a030c5461ba4e449a2c45eae6fdfcb4543/src/routes/login/username/%2Bpage.svelte#L101C9-L103C14

@JoshKamps JoshKamps changed the title Form validation doesn't check for validty Form validation doesn't check for validity Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant