Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic reconcile #8319

Open
3 tasks done
cestpasphoto opened this issue Jan 2, 2024 · 2 comments
Open
3 tasks done

Automatic reconcile #8319

cestpasphoto opened this issue Jan 2, 2024 · 2 comments
Labels
enhancement Requests for enhancements of existing stuff.

Comments

@cestpasphoto
Copy link

Support guidelines

Description

In reconcile screen, I would like just to enter the current total amount and Firefly would automatically suggests which boxes to tick and which ones to leave unticked.

Solution

I implemented a solution in my fork since more than a year and it is super convenient to my point of view. I can submit a pull request, but first please check the limitations of my implementation especially on frontend.

Backend: the problem is similar to the common knapsack problem, so no difficulty. The only difficulty is to limit the computation time in large cases: for instance there are more than 10M combinations of 9+ unchecked boxes among 30 operations, we would check only combinations with 8 unchecked boxes or less.

Frontend: I am not a frontend guy the user experience is dirty. The computations are done in client side in javascript. It is triggered by the user deselecting the reconciliation amount. If it succeeds, then it checks relevant boxes automatically; if it fails, nothing happens except a message in the console. Maybe it would be better to have a dedicated button to trigger the auto reconcile, and then an alert messagebox if fails or redirect to confirmation window if success.

What are alternatives?

No response

Additional context

User would type the amount:
1_user_types_amount

Then the user deselects such field (field looses focus) and firefly automatically selects the relevant boxes:
2_firefly_checks_relevant_boxes

@JC5
Copy link
Member

JC5 commented Jan 2, 2024

Nice work!

I'm going to remember this for the new layout: #6302

For now, I don't want to make too many changes, especially not to the reconciliation form. It's kind of a mess anyway and it needs a major overhaul.

@JC5 JC5 added the enhancement Requests for enhancements of existing stuff. label Jan 2, 2024
@JC5 JC5 added this to the firefly-iii-v9.0.0 milestone Jan 2, 2024
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Hi there! This is an automatic reply. Share and enjoy

This issue has been marked as an enhancement. The requested enhancement to an existing feature will become a part of Firefly III or the data importer in due course.

If you come across this issue, please be aware there is NO need to reply with "+1" or "me too" or "I need this too" or whatever. Such comments are not helpful, and do not influence the roadmap. Your comment may be 💀 deleted. You can subscribe to this issue to get updates.

Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests for enhancements of existing stuff.
Projects
Status: To do
Development

No branches or pull requests

2 participants