Data importer fails to import a transaction with amount (in foreign currency) and currency code

[citxx]

Support guidelines

• I've read the support guidelines

I've found a bug and checked that ...

• ... the documentation does not mention anything about my problem
• ... there are no open or closed issues that are related to my problem
• ... it's definitely a Firefly III issue, not me

Description

Data importer fails to import a transaction on the "data submission" step with the following error:

Line #0: transactions.0.foreign_amount: The content of this field is invalid without currency information. (original value: "8.000000000000")

This happens while both Amount (in foreign currency) and Currency code (ISO 4217) fields are present in CSV and correctly assigned in data importer.

Debug information

Debug information generated at 2024-04-22 23:56:50 for Firefly III version v6.1.13.

System information
Item	Value
Firefly III	6.1.13 / v2.0.13 / 23 (exp. 23)
PHP version	8.3.4 (64bits) / apache2handler / Linux x86_64
BCscale	12
Error reporting	Display: Off, reporting: ALL errors
Max upload	67108864 (64 MB)
Database drivers	*mysql*, pgsql, sqlite,
Docker build	#1052, base #82

Firefly III information
Item	Value
Timezone	Europe/Berlin + Europe/Berlin
App environment	production, debug: false
Layout	v1
Logging	notice, stack / (empty)
Cache driver	file
Default language and locale	en_US + equal
Trusted proxies	**
Login provider & user guard	eloquent / web
Login headers	N/A + N/A
Stateful domains
Last cron job	2024-04-21 22:00:00 (23 hours ago)
Mailer	log

User-specific information
Item	Value
User	#1 of 1
User flags	🔧 📑 📧
Session start	2024-01-01 00:00:00
Session end	2024-04-22 22:59:48
View range	1M
User language	en_US
User locale	en_US
Locale(s) supported	en_US.utf8: ✅ en_US.UTF-8: ✅
User agent	Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Safari/537.36

Expected behaviour

The transaction should be imported.

Steps to reproduce

I was able to reproduce the bug on the demo instance with demo importer as well:

1. Open https://data-importer.firefly-iii.org/
2. Use https://demo.firefly-iii.org/ as URL and 4 as Client ID
3. Import file, then use transactions-example.csv and config-example.json
4. Submit until you see the Map data screen
5. Chose Hungarian forint as the mapped value for the only currency code.
6. Proceed with import

The problem is still present without mapping, but then THB should be replaced in CSV file with a currency existing in the demo instance (e.g. HUF).

Additional info

I hope it's not a stupid mistake by me, that I wasn't able to find after checking multiple times 😅

Relevant importer logs:

[2024-04-22 23:29:31] local.INFO: Now in App\Services\CSV\Conversion\Routine\CSVFileProcessor::processCSVLines with 1 records  
[2024-04-22 23:29:31] local.INFO: Parsed all 1 lines.  
[2024-04-22 23:29:31] local.INFO: Going to remove duplicate lines.  
[2024-04-22 23:29:31] local.INFO: Went from 1 line(s) to 1 line(s)  
[2024-04-22 23:29:31] local.INFO: Now processing the data in the 1 CSV lines...  
[2024-04-22 23:29:31] local.INFO: Done processing data in 1 CSV lines...  
[2024-04-22 23:29:31] local.INFO: Now parsing and combining 1 lines.  
[2024-04-22 23:29:31] local.INFO: Done parsing and combining 1 lines.  
[2024-04-22 23:29:31] local.INFO: Converting 1 line(s) into transactions.  
[2024-04-22 23:29:31] local.INFO: Now processing line 1/1.  
[2024-04-22 23:29:31] local.INFO: Done converting 1 line(s) into transactions.  
...
[2024-04-22 23:29:41] local.INFO: Going to submit 1 transactions to your Firefly III instance.  
[2024-04-22 23:29:41] local.ERROR: Submission error: 0 ["The content of this field is invalid without currency information."] 
[2024-04-22 23:29:41] local.ERROR: Add error to index #0: transactions.0.foreign_amount: The content of this field is invalid without currency information. (original value: "8.000000000000")  
[2024-04-22 23:29:41] local.ERROR: transactions.0.foreign_amount: The content of this field is invalid without currency information. (original value: "8.000000000000")  
[2024-04-22 23:29:41] local.INFO: Done submitting 1 transactions to your Firefly III instance.  

[JC5]

Hi,

Please select "Foreign currency code (ISO 4217)", that should do the trick.

[citxx]

Thanks for the help! It was a stupid mistake in the end :)

It might be easier for new users to avoid this mistake if "Currency code" and "Foreign currency code" were next to each other in the dropdown.