New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] for sample: https://github.com/firebase/functions-samples/tree/main/2nd-gen/instrument-with-opentelemetry #1021
Comments
Yeah been trying to set this up using NODE_OPTIONS but can't get it working. @taeold Really excited about this but would love your input! 🙏 |
By the way @dan-wu-open I think you might be able to get what you're looking for by setting an environment variable called https://console.cloud.google.com/functions/list Give it a try 😄 |
I am struggling with setting this up in TypeScript, somehow my custom spans are not visible. |
Whoops my mistake. Thanks for calling it out @dan-wu-open and @adamaffinitech. Fix incoming at #1022 |
@kaczors Thanks for sharing your problem. It's a real bummer that we don't get to configure the Cloud Run sampling rate :(. I believe Open Telemetry allows you to configure a sampler that can override the 0.1 sampling rate of Cloud Run. See https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#built-in-samplers. Unfortunately, this would mean that you won't have the overarching request span generated by the Cloud Run's load balancer, but you'd at least be getting spans generated by your application. I will take a closer look and see if I can write some sample code this weekend. If you are willing to share your work, I think the community will appreciate it! |
Do you happen to have any working code around this? I'm using v2 callable functions but only the |
sorry, I did not found any workaround and not using this solution anymore |
Which sample?
https://github.com/firebase/functions-samples/tree/main/2nd-gen/instrument-with-opentelemetry
What is the issue with this sample's docs?
The docs mention a
./.env
file but I don't see it. Would appreciate it to see how it's set up! Would love to add telemetry to all of our cloud functionsThe text was updated successfully, but these errors were encountered: