Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃殌 [firebase_app_check] Support passing debugToken as parameter similar to React Native App Check library #11719

Open
thedalelakes opened this issue Oct 17, 2023 · 5 comments 路 May be fixed by #12672
Open

馃殌 [firebase_app_check] Support passing debugToken as parameter similar to React Native App Check library #11719

thedalelakes opened this issue Oct 17, 2023 · 5 comments 路 May be fixed by #12672
Labels
platform: all Issues / PRs which are for all platforms. plugin: app_check type: enhancement New feature or request

Comments

@thedalelakes
Copy link

thedalelakes commented Oct 17, 2023 •
edited

What feature would you like to see?

In the React Native package for Firebase App Check, they created their own custom provider that essentially overrides the debug provider token. This allows a developer to specify a static, generated debug token in their code to use.

This is very convenient because, in the case where the developer must uninstall / reinstall the app, they can use the same debug token. Currently, a Flutter developer that installs a new version of the app must manually copy and paste the debug token from XCode / Logcat console output into their Firebase web console (and delete the old token), which becomes tedious when testing certain functionality that requires fresh installations of the application.

Relevant links & code:
@thedalelakes thedalelakes added Needs Attention This issue needs maintainer attention. type: enhancement New feature or request labels Oct 17, 2023
@darshankawar darshankawar added triage Issue is currently being triaged. plugin: app_check and removed Needs Attention This issue needs maintainer attention. triage Issue is currently being triaged. labels Oct 18, 2023
@thedalelakes
Copy link
Author

thedalelakes commented Oct 25, 2023 •
edited

I'm willing to complete this issue myself and submit a PR for it. I just want to first make sure that this feature would actually be accepted by the Firebase / FlutterFire core maintainers, given the security implications.

@darshankawar darshankawar mentioned this issue Jan 31, 2024
Open
@Lyokone Lyokone added the platform: all Issues / PRs which are for all platforms. label Mar 19, 2024
@xVemu
Copy link

xVemu commented Mar 25, 2024

It's also useful for tests in CI.

@josh-burton
Copy link
Contributor

We really need this for debug tokens to be useful and maintainable. We're generating and updating our debug tokens via Terraform, but currently we can't use these in the Flutter apps as there is no method to supply our own token.

@thedalelakes did you ever get to work on a PR for this?

@thedalelakes
Copy link
Author

@josh-burton unfortunately I don't have the time to work on this at the moment. I ended up just turning off App Check enforcement in my dev environment.

@xVemu xVemu linked a pull request Apr 19, 2024 that will close this issue
Open
10 tasks
@xVemu
Copy link

xVemu commented Apr 19, 2024 •
edited

I think on IOS you can use point 4 from guideline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
platform: all Issues / PRs which are for all platforms. plugin: app_check type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
5 participants
@josh-burton @Lyokone @xVemu @darshankawar @thedalelakes