Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 [firebase-database] Apply sort/compare onChildChanged. #12657

Open
aymaalo opened this issue Apr 16, 2024 · 2 comments 路 May be fixed by #12664
Open

馃悰 [firebase-database] Apply sort/compare onChildChanged. #12657

aymaalo opened this issue Apr 16, 2024 · 2 comments 路 May be fixed by #12664
Labels
Needs Attention This issue needs maintainer attention. platform: all Issues / PRs which are for all platforms. plugin: database type: enhancement New feature or request

Comments

@aymaalo
Copy link

aymaalo commented Apr 16, 2024

Apply sort/compare onChildChanged.

When I update my item in firebase real-time database, I would like my FirebaseAnimatedList() widget to apply the sort.
Example: I add a child to my query something.child($id)

This can be fixed manually in firebase-database/ui/firebase_sorted_list.dart by adding _snapshots.sort(comparator); before onChildChanged!(index, event.snapshot); line 114.
@aymaalo aymaalo added Needs Attention This issue needs maintainer attention. type: enhancement New feature or request labels Apr 16, 2024
@russellwheatley russellwheatley added plugin: database platform: all Issues / PRs which are for all platforms. and removed Needs Attention This issue needs maintainer attention. labels Apr 17, 2024
@russellwheatley
Copy link
Member

@aymaalo - do you mind opening a PR with this change, please? I am interested because it does seem like the list should be sorted particularly when the whole point of FirebaseSortedList is to sort it.

@russellwheatley russellwheatley added the blocked: customer-response Waiting for customer response, e.g. more information was requested. label Apr 17, 2024
@aymaalo aymaalo linked a pull request Apr 17, 2024 that will close this issue
Open
10 tasks
@aymaalo
Copy link
Author

aymaalo commented Apr 17, 2024

PR created: #12664

This is my first PR contribution on a open-source project, so let me know if there is something I forgot/missed.

@google-oss-bot google-oss-bot added Needs Attention This issue needs maintainer attention. and removed blocked: customer-response Waiting for customer response, e.g. more information was requested. labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Attention This issue needs maintainer attention. platform: all Issues / PRs which are for all platforms. plugin: database type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(database): sorting was not applied when database child changed. aymaalo/flutterfire
3 participants
@russellwheatley @google-oss-bot @aymaalo