Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FirebaseInAppMessaging pod installs FirebaseAnalytics/AdIdSupport #12810

Open
danielsefton opened this issue Apr 18, 2024 · 6 comments
Open

FirebaseInAppMessaging pod installs FirebaseAnalytics/AdIdSupport #12810

danielsefton opened this issue Apr 18, 2024 · 6 comments
Assignees
Labels
api: inappmessaging Firebase In App Messaging Docs

Comments

@danielsefton
Copy link

danielsefton commented Apr 18, 2024

Description

In my podfile I have 'FirebaseAnalytics/WithoutAdIdSupport'

When I add 'FirebaseInAppMessaging' to my podfile then it installs 'FirebaseAnalytics/AdIdSupport'

Here are the dependencies listed in the lock file with 'FirebaseInAppMessaging':

- FirebaseInAppMessaging (0.13.0):
  - FirebaseAnalytics
  - FirebaseAnalyticsInterop
  - FirebaseCore
  - FirebaseInstanceID

I don't see a way to stop it from installing the full FirebaseAnalytics package.

However, when I use 'Firebase/InAppMessaging' (notice the extra /) then it seems to install the pod without the dependency to FirebaseAnalytics:

- FirebaseInAppMessaging (10.24.0-beta):
  - FirebaseABTesting (~> 10.0)
  - FirebaseCore (~> 10.0)
  - FirebaseInstallations (~> 10.0)
  - GoogleUtilities/Environment (~> 7.8)
  - nanopb (< 2.30911.0, >= 2.30908.0)

Looking at the FirebaseInAppMessaging podspec, the above set of dependencies seem to be correct.

I noticed the non-slash package is version 0.13.0 (incorrect), and the slash package is 10.24.0-beta (correct).

In the docs it recommends the pods without the slashes. All is fine with the other packages without the slash, but it seems like I need to make an exception for InAppMessaging:

https://firebase.google.com/docs/ios/setup#available-pods

Firebase SDK Version

10.24.0

Xcode Version

15.3

Installation Method

CocoaPods

Firebase Product(s)

In-App Messaging

Targeted Platforms

iOS

@google-oss-bot
Copy link

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@rizafran rizafran added api: inappmessaging Firebase In App Messaging and removed needs-triage labels Apr 18, 2024
@rizafran
Copy link
Contributor

Hi @danielsefton, you may try using pod 'FirebaseInAppMessaging', '10.24-beta' to install the latest version of FirebaseInAppMessaging.

@paulb777
Copy link
Member

Or pod 'FirebaseInAppMessaging', '> 10.24-beta' to get the latest version now and in the future.

@danielsefton
Copy link
Author

Hi rizafran (and paulb777), thank you for the replies, although, it's not really completed? Surely it should still match the behaviour of the other pods and reliably install the latest version without the need to specify it manually? Anyone who follows the docs will run into the same issue so it should still be fixed imo.

@paulb777
Copy link
Member

Yes, FirebaseInAppMessaging is still in beta and we want users to be aware of that before installing.

Would you let us know where the docs gave the wrong guidance?

@paulb777 paulb777 reopened this Apr 18, 2024
@paulb777 paulb777 added the Docs label Apr 18, 2024
@danielsefton
Copy link
Author

Ah, I wasn't aware it was in beta. I am fairly new to Firebase and just saw that it was available in the Firebase admin panel, then proceeded to set it up via the docs. I don't see anywhere that it says it's in beta:

Admin panel - no beta reference
Guide: https://firebase.google.com/docs/in-app-messaging - no beta reference
Available pods: https://firebase.google.com/docs/ios/setup#available-pods - no beta reference

So people will just add the pod and not think twice that it installs an incorrect version (0.13.0) by default, which actually adds the analytics with ad id support, so it creates a potential privacy issue as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: inappmessaging Firebase In App Messaging Docs
Projects
None yet
Development

No branches or pull requests

5 participants