WIP: Fix issue where emulator connects to the wrong host upon reconnect #5903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Generated by 🚫 Danger |
Coverage Report 1Affected Products
Test Logs |
Size Report 1Affected ProductsTest Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Startup time comparison between the CI merge commit (d90430e) and the base commit (68fb692) are not available. No macrobenchmark data found for the base commit (68fb692). Analysis for the CI merge commit (d90430e) can be found at: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the handshake with the WebSocket is complete, the server responds with the host name and port, which we then use upon reconnection.
When using the firebase emulator, the server defaults to the host and port mentioned in the
firebase.json, but if the user is using a different host name to connect to the firebase emulator (such as 10.0.2.2 when the Android Emulator talks to the host machine's server), we end up caching the host name infirebase.jsonand end up reconnecting to the wrong host name and port.This PR attempts to introduce state called
isUsingEmulatorto prevent caching of the hostname, and therefore connecting to the default host name provided by the user's config.Fixes #5870