Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature firestore: add CustomClassMapper#convertBigDecimal for Deserializer #1887

Closed
lshens opened this issue Aug 17, 2020 · 4 comments
Closed

feature firestore: add CustomClassMapper#convertBigDecimal for Deserializer #1887

lshens opened this issue Aug 17, 2020 · 4 comments
Assignees
@schmidt-sebastian
Labels
api: firestore type: feature request New feature or request

Comments

@lshens
Copy link

lshens commented Aug 17, 2020

What feature would you like to see?

The SDK must have support for BigDecimal type as we do in the google-cloud-firestore.

How would you use it?

The BigDecimal helps the developer to do any calculation without losing the precision of the number (this happens with double), this feature you also improve the management of monetary types.
@google-oss-bot
Copy link
Contributor

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@lshens lshens changed the title feat: add CustomClassMapper#convertBigDecimal for Deserializer feature firestore: add CustomClassMapper#convertBigDecimal for Deserializer Aug 17, 2020
@schmidt-sebastian
Copy link
Contributor

Will discuss with team and update you either this or next week.

@schmidt-sebastian
Copy link
Contributor

@lshens Can you explain your use case a bit more? We are worried that a String representation of numbers might not work for everyone, since string-encoded numbers will sort as strings.

@rlazo rlazo added type: feature request New feature or request and removed needs-triage labels Aug 19, 2020
@schmidt-sebastian
Copy link
Contributor

Closing this due to inactivity. Please re-open if this is still an issue.

@firebase firebase locked and limited conversation to collaborators Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore type: feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ashwinraghav @rlazo @lshens @schmidt-sebastian @google-oss-bot