Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] adding toJSON property to the Admin SDK Timestamp class #2412

Open
tlserver opened this issue Dec 14, 2023 · 1 comment
Open

[FR] adding toJSON property to the Admin SDK Timestamp class #2412

tlserver opened this issue Dec 14, 2023 · 1 comment

Comments

@tlserver
Copy link

Is your feature request related to a problem? Please describe.
Working in monorepos or other situations with shared Typescript interfaces is complicated because toJSON property is missing on the Admin SDK Timestamp definition

Can firebase-admin package and firebase package share same type definition of some common class?
For example firebase-admin Timestamp class is defined here but firebase Timestamp class is defined here and they are different.

Describe the solution you'd like
adding toJSON property to the Admin SDK Timestamp class to make it compatible to firebase Timestamp class.

Describe alternatives you've considered
Split the common class type definition to a separate package?

Additional context
Discussed at #1404 before, but no contributor response after hiranya911 is not active in firebase project.

@google-oss-bot
Copy link

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants