Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To-do: #3

Open
9 of 33 tasks
fintzij opened this issue Jul 1, 2020 · 3 comments
Open
9 of 33 tasks

To-do: #3

fintzij opened this issue Jul 1, 2020 · 3 comments
Assignees

Comments

@fintzij
Copy link
Owner

fintzij commented Jul 1, 2020

Running list of various things I need to update in this package:

  • Resolve crashing due to bug in XPtr destruction.
  • Ryacas compatibility
  • Get rid of t0 inference.
  • Block sampling for parameters with MH + adaptive MCMC infrastructure. Should be similar to MVNSS.
  • Allow for different samplers for different blocks of parameters.
  • Unified wrapper for LNA and ODE inference.
  • Minweke tests for samplers.
  • Beta-binomial emission distribution.
  • Remove beta-binomial and link against extraDistr headers if that package ever exports functions to make them C++ callable.
  • compile dynamics and measurement process together in make_stem instead of in stem_dynamics and stem_measurement separately.
  • fit_stem should return the log-posterior so the user doesn't always have to sum it's constituent parts.
  • Flag for parameters that are declared but never used.
  • Only allow a stem object to have one method compiled at a time for safety.
  • Option to sample marginal posterior LNA paths by sampling additional standard normal random variates not conditioned on data but conditional on posterior draws of model parameters.
  • Retool and streamline simulation/prediction.
  • New vignettes.
  • Utility functions for posterior processing.
  • Push to CRAN? Is this worth the headache?
  • Refactor handling of strata so they are conditionally independent (MAJOR update).
  • Functionality for within-chain parallelization to solve ODEs for conditionally independent strata (MAJOR update).
  • Tidy MCMC objects?
  • Improve parsing functions
  • Transfer errors and warnings to self contained functions for checking validity of model specification.
  • Verify that measurement processes related to prevalence are handled correctly in inference.
  • Allow for LNA not to necessarily restart at every time point.
  • Return only lower triangular part of LNA covariance when solving ODEs. No need to return the entire matrix.
  • Custom measurement processes to allow for second stage model as well as reporting delays in the future.
  • With previous task, function to give sample objects to help user define likelihood.
  • Option to return centered LNA moments when simulating/doing inference. Option not to return non-centered LNA draws.
  • Solve ODEs using Julia solvers or with Stan instead of Boost? Is this possible?
  • testing with testthat
  • report coverage with covr
  • allow for time varying parameters that are a function of time varying covariates and time homogeneous parameters
@fintzij fintzij self-assigned this Jul 1, 2020
@damonbayer
Copy link
Collaborator

Re: Solve ODEs using Julia solvers or with Stan instead of Boost? Is this possible?

https://github.com/SciML/diffeqr

@kevinkiernan
Copy link

New vignettes would be greatly appreciated! I had the previous version of stemr working well for generating SEMs for the COVID outbreak based on death incidence, but the update to Ryacas broke my workflow.

If new vignettes are not imminent, perhaps I could get the answers to a couple of questions?

  1. For the priors input to the function parblocks, is logprior the same function as what you were calling prior_density in previous versions? If not, how is logprior specified?
  2. Is the intializer input to parblocks used to initialize the parameters in the same manner as the function assigned to stemobj$dynamics$parameters in previous versions? (i.e. to add a random perturbation to the starting parameter value)

These were my assumptions after reading the commented code, but I get an initialization error when fit_stem tries to call initialize_lna.

@fintzij
Copy link
Owner Author

fintzij commented Sep 14, 2020

Moved questions from @kevinkiernan to a separate thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants