Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search API response when no matches found #47

Open
greg-wiltshire opened this issue Apr 22, 2021 · 1 comment
Open

Search API response when no matches found #47

greg-wiltshire opened this issue Apr 22, 2021 · 1 comment

Comments

@greg-wiltshire
Copy link
Contributor

The search API currently returns an empty object if there is no match found. I propose that this is modified to be

{searchResult: []}

which will mean that downstream code will not have to check for the property.

@martin-traverse
Copy link
Contributor

I think this is a feature of protobuf and carried over to protobufjs, which is the foundation of our web API bindings. We might be able to address it with a generation option in the protobufjs code generation step, although that seems unlikely since this is the semantics of protobuf itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants