Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve developer guide #665

Open
natrem opened this issue Oct 5, 2023 · 2 comments
Open

Improve developer guide #665

natrem opened this issue Oct 5, 2023 · 2 comments
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@natrem
Copy link

natrem commented Oct 5, 2023

I tried building this project, as a dependency for common-domain-model, but not published to standard maven repositories.
1- Is there a place to download binaries for rosetta?

When building from maven (one step at a time), I encountered several issues, that may be worth checking.

  1. The developer guide indicates using java 11, but the root pom enforces java 17

  2. The module com.regnosys.rosetta, during the mwe2Launcher execution, downloads SNAPSHOT dependencies for eclipse emf and core. I did not manage to find the root cause, but the work-around is to add the following maven settings (corporate mirror):

<mirror>
      <id>proxy-ossrh-sonatype</id>
      <mirrorOf>ossrh-snapshots</mirrorOf>
      <url>https://my-nexus-proxy.com/repository/oss-sonatype-snapshots/</url>
    </mirror>

Is it normal to rely on SNAPSHOT dependencies?

  1. In the same module, generation relies on antlr. In module com.regnosys.rosetta.ide nodeJs is required, and downloaded. Both downloads require maven configuration for proxy: ``mvn -D"http.proxyHost"=proxy.host.com -D"http.proxyPort"=the_port install"
    Although it's not entirely specific to rosetta, the proxy limitations are a bit behind standard usage, so I think it's worth mentioning.

5. I'm now at rosetta-tools module, with failing tests. I probably need to set a version for the tests to pass. More to come 😄 This setup should probably appear in the documentation too. Found my issue, related to execution platform (PR to come).

@SimonCockx
Copy link
Contributor

SimonCockx commented Oct 5, 2023

Hey @natrem, thanks for all of the feedback! I will try to verify and address your comments in the coming days. Feel free to reach out if you require further help to setup this project (although you do seem to be getting there on your own :) ).

Out of curiosity, may I ask what is your interest in this project?

@SimonCockx SimonCockx added documentation Improvements or additions to documentation bug Something isn't working labels Oct 5, 2023
@natrem
Copy link
Author

natrem commented Oct 6, 2023

I'm interested in the project in order to check out the CDM, in context on my work at Societe Generale (for a colleague actually).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants