Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Locale support #1725

Open
jpenren opened this issue Nov 4, 2021 · 1 comment
Open

Locale support #1725

jpenren opened this issue Nov 4, 2021 · 1 comment
Labels
enhancement Issues related to improving the codebase, the documentation or process within the project

Comments

@jpenren
Copy link

jpenren commented Nov 4, 2021

Feature request

Java Faker library has support for multiple locales Faker faker = new Faker(new Locale("YOUR_LOCALE")); but this is not used in DataHelix. This is an important feature to gain significant data: names, cities are some examples. Perhaps use system locale or a new parameter to establish the locale...

@jpenren jpenren added the enhancement Issues related to improving the codebase, the documentation or process within the project label Nov 4, 2021
@laingsimon
Copy link

Looks like a change to this class could be made.
https://github.com/finos/datahelix/blob/master/core/src/main/java/com/scottlogic/datahelix/generator/core/generation/string/generators/FakerGenerator.java

Things to consider:

  • will there be a desire for different locales per field or branch of the profile?
    • if so there may be the need to branch for values that do and don't respect the locale
    • e.g. en-GB:name.firstName and not(en-GB):name.firstName
  • is a 'config' setting the right approach to provide a fallback/default value? Options are:
    • a setting in the profile itself, e.g. profile settings/defaults
    • a command line switch or environment variable
    • or don't provide a fallback and fail the profile of not explicitly defined

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Issues related to improving the codebase, the documentation or process within the project
Projects
None yet
Development

No branches or pull requests

2 participants