Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Improve profile module further #1534

Open
5 tasks
cdowding-sl opened this issue Nov 12, 2019 · 0 comments
Open
5 tasks

Improve profile module further #1534

cdowding-sl opened this issue Nov 12, 2019 · 0 comments
Projects
Version 1
Milestone
Improve Profile UX

Comments

@cdowding-sl
Copy link
Contributor

cdowding-sl commented Nov 12, 2019 •
edited

Feature Request

There are still a few outstanding architectural issues as well as simplifications that can be made to the profile. Additionally validation is not fully complete and could be improved upon.

Tasks

  • Decouple the ui json from the profile
  • Add type validation
  • Add ui to profile mapping
  • Add missing validation: schema version, specific constraint validation
  • Refactor FileReader. CsvInputStreamReader, and NameRetrievalService into the improved architecture

Estimate - 2
@cdowding-sl cdowding-sl added this to the Improve Profile UX milestone Nov 12, 2019
@cdowding-sl cdowding-sl self-assigned this Nov 12, 2019
@cdowding-sl cdowding-sl added this to Unprioritised in Version 1 via automation Nov 12, 2019
@cdowding-sl cdowding-sl moved this from Unprioritised to In progress in Version 1 Nov 12, 2019
@cdowding-sl cdowding-sl moved this from In progress to To do in Version 1 Nov 14, 2019
@cdowding-sl cdowding-sl moved this from To do to Ready in Version 1 Nov 18, 2019
@cdowding-sl cdowding-sl moved this from Ready to In progress in Version 1 Nov 18, 2019
@cdowding-sl cdowding-sl moved this from In progress to Unprioritised in Version 1 Nov 19, 2019
sl-slaing added a commit that referenced this issue Jan 31, 2020
@sl-slaing
refactor(#1534): Use composition to control generation behaviour
c77df08
sl-slaing added a commit that referenced this issue Jan 31, 2020
@sl-slaing
refactor(#1534): Refactor profile reading to use injected deserialiser
e51c39c
This was referenced Jan 31, 2020
Merged
Merged
sl-slaing added a commit that referenced this issue Jan 31, 2020
@sl-slaing
refactor(#1534): Refactor profile reading to use injected deserialiser
795be96
sl-slaing added a commit that referenced this issue Jan 31, 2020
@sl-slaing
refactor(#1534): Use composition to control generation behaviour
b4d80f6
sl-slaing added a commit that referenced this issue Jan 31, 2020
@sl-slaing
refactor(#1534): Use composition to control generation behaviour
065cbef
sl-slaing added a commit that referenced this issue Jan 31, 2020
@sl-slaing
refactory(#1534): Remove unnecessary imports
dc2e3fe
sl-slaing added a commit that referenced this issue Jan 31, 2020
@sl-slaing
refactor(#1534): Remove accidentally included deserialisation feature
0b2c8c5
sl-slaing added a commit that referenced this issue Jan 31, 2020
@sl-slaing
Merge pull request #1654 from finos/refactor/1534-composed-generators
f4bbe30 
refactor(#1534): Use composition to control generation behaviour
sl-slaing added a commit that referenced this issue Jan 31, 2020
@sl-slaing
refactory(#1534): Remove redunant import
03d4c98
sl-slaing added a commit that referenced this issue Jan 31, 2020
@sl-slaing
refactor(#1534): Add test scenario for sub-folder file reading
7130791
sl-slaing added a commit that referenced this issue Jan 31, 2020
@sl-slaing
Merge pull request #1655 from finos/refactor/1534-reading-improvements
6f03e58 
refactor(#1534): Refactor profile reading to use injected deserialiser
@sl-slaing sl-slaing mentioned this issue May 15, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Version 1
  
Unprioritised
Milestone
Improve Profile UX
Development

No branches or pull requests
1 participant
@cdowding-sl