rename BlockSync to ChainExchange #1204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy is failing probably because I should have updated some index after changing file names, I'll leave that to you @yiannisbot. |
austinabell
previously approved these changes
Oct 12, 2020
yiannisbot
reviewed
Oct 14, 2020
Co-authored-by: Yiannis Psaras <52073247+yiannisbot@users.noreply.github.com>
hugomrdias
suggested changes
Oct 15, 2020
| If not all Tipsets requested could be fetched, but the `Head` of the chain segment requested was successfully fetched (and potentially more contiguous Tipsets), then this is not considered an error and a `Partial` response code is returned. The node can continue extending the chain from the partial returned segment onwards. | ||
|
|
||
| ```go | ||
| type Request struct { |
There was a problem hiding this comment.
you can embed this struct directly from the code https://github.com/filecoin-project/lotus/blob/master/chain/exchange/protocol.go#L48-L60 using https://github.com/filecoin-project/specs#embed
Example:
{{<embed src="https://github.com/filecoin-project/lotus/blob/master/chain/exchange/protocol.go" lang="go" symbol="Request" title="Exchange Protocol Request">}}
This way its easier to keep in sync.
|
Can you rebase please ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates names from filecoin-project/lotus#3624 and some protocol packet structure from filecoin-project/lotus#2715.
Closes #1171.