Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move API and VM crates from anorth/fvm-workbench into this repo #1960

Open
anorth opened this issue Jan 9, 2024 · 0 comments
Open

Move API and VM crates from anorth/fvm-workbench into this repo #1960

anorth opened this issue Jan 9, 2024 · 0 comments

Comments

@anorth
Copy link
Member

anorth commented Jan 9, 2024

The fvm-workbench is a testing platform that executes actor code on a stand-alone VM. It is especially useful for gas tracing.

Two of its three crates are independent of the built-in actors. Its API defines an API that is also implemented by the built-in actors integration test VM (that exercises actors as non-WASM). That API is currently duplicated as we have elected not to have the built-in actors repo depend on that workbench. After moving the crates in to this repo though

  1. it will be reasonable for the built-in actors to import it, removing the duplication
  2. it will be much easier to keep all three in sync as the VM changes

The third crate depends on the built-in actors repo in order to import its integration tests and execute them. We don't want to move that one in here, but have it depend on the moved API crates.

This repo already has some testing infrastructure. I believe our long term wish is to remove it in favour of the fvm-workbench. That might need to be incremental, rewriting the internal tests that use it to use the new thing instead.

See also discussion https://filecoinproject.slack.com/archives/C015KQQLQQ1/p1697750224746249

FYI @Stebalien @aarshkshah1992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant