Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of float operators in the future WASM Actors implementation #1827

Open
BlocksOnAChain opened this issue Jul 31, 2023 · 6 comments
Open

Comments

@BlocksOnAChain
Copy link
Collaborator

Context:
Good future question to resolve as we move closer to Wasm Acorst being on Mainnet - Will custom actors targeting Wasm be allowed to use float operators?
We need to see if they will be "allowed", once WASM actors become available on Mainnet.
Example from the industry - Cosmwasm, has some static analysis that blocks wasm contracts that contain float operators, which is a great feature to have.

Read more about it: https://filecoinproject.slack.com/archives/CRK2LKYHW/p1689371676829989?thread_ts=1689170374.514469&cid=CRK2LKYHW

@Stebalien
Copy link
Member

Stebalien commented Jul 31, 2023

Part of #730

@Jacarte
Copy link
Collaborator

Jacarte commented Jul 31, 2023

Part of #1038?

@Stebalien
Copy link
Member

Ah, that too, yes. E_TOO_MANY_ISSUES.

@Jacarte
Copy link
Collaborator

Jacarte commented Jul 31, 2023

Including it then in the current MVP

@Jacarte
Copy link
Collaborator

Jacarte commented Jul 31, 2023

Uhmm, yet wasmtime has canonicalization of floats, at least for NaN, https://docs.wasmtime.dev/api/wasmtime/struct.Config.html#method.cranelift_nan_canonicalization

@Stebalien
Copy link
Member

Yes. That's the feature we plan on using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants