Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filecoin should support legacy Homstead and legacy EIP-155 Ethereum transactions #11859

Open
4 of 9 tasks
aarshkshah1992 opened this issue Apr 9, 2024 · 3 comments
Open
4 of 9 tasks

Filecoin should support legacy Homstead and legacy EIP-155 Ethereum transactions #11859

aarshkshah1992 opened this issue Apr 9, 2024 · 3 comments
Assignees
@aarshkshah1992
Labels
kind/feature Kind: Feature

Comments

@aarshkshah1992
Copy link
Contributor

Checklist

  • This is not brainstorming ideas. If you have an idea you'd like to discuss, please open a new discussion on the lotus forum and select the category as Ideas.
  • I have a specific, actionable, and well motivated feature request to propose.

Lotus component

  • lotus daemon - chain sync
  • lotus fvm/fevm - Lotus FVM and FEVM interactions
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt/WinningPoSt)
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

What is the motivation behind this feature request? Is your feature request related to a problem? Please describe.

This issue has been created to add support for legacy transactions to Filecoin so that contracts and user transactions are not scoped to a specific chain. Specifically, this issue tracks FIP discussion at filecoin-project/FIPs#962.

Describe the solution you'd like

Option #3 on filecoin-project/FIPs#962

"We could also prepend a transaction type byte to the signature field (for Ethereum transactions only). IMO, this is the best solution, but it may break any tooling manually signing/validating messages from Ethereum accounts. On the other hand, I'm doubtful any tooling like this exists, so we're probably fine."

Describe alternatives you've considered

No response

Additional context

No response
@aarshkshah1992 aarshkshah1992 added the kind/feature Kind: Feature label Apr 9, 2024
@aarshkshah1992 aarshkshah1992 self-assigned this Apr 9, 2024
@aarshkshah1992
Copy link
Contributor Author

@Stebalien

Just to clarify, when we support legacy transactions - do we mean
Transactions without Chain ID OR
Transactions without ChainID AND without any of the EIP-1599 gas stuff params ?

@Stebalien
Copy link
Member

Hm. It's going to have to be the latter, I think (needs to be bit for bit compatible). I think we need to set the GasPremium to GasFeeCap when translating from the EthTxn to the Filecoin message.

@Stebalien
Copy link
Member

Yeah, from what I can tell, the premium is the gas fee. The FVM will subtract out whatever it needs to burn before giving the rest to the SP.

@aarshkshah1992 aarshkshah1992 mentioned this issue Apr 10, 2024
Closed
8 tasks
@aarshkshah1992 aarshkshah1992 mentioned this issue Apr 26, 2024
Closed
8 tasks
@rjan90 rjan90 mentioned this issue May 6, 2024
Closed
@aarshkshah1992 aarshkshah1992 changed the title Filecoin should support legacy Ethereum transactions Filecoin should support legacy Homstead and legacy EIP-155 Ethereum transactions May 6, 2024
This was referenced May 7, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aarshkshah1992 aarshkshah1992

Labels
kind/feature Kind: Feature
Projects
None yet
Milestone
No milestone
2 participants
@Stebalien @aarshkshah1992