Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test FIP-0085 once migration integrated #11896

Closed
3 of 9 tasks
ZenGround0 opened this issue Apr 18, 2024 · 2 comments
Closed
3 of 9 tasks

Test FIP-0085 once migration integrated #11896

ZenGround0 opened this issue Apr 18, 2024 · 2 comments
Assignees
Milestone

Comments

@ZenGround0
Copy link
Contributor

Checklist

  • This is not brainstorming ideas. If you have an idea you'd like to discuss, please open a new discussion on the lotus forum and select the category as Ideas.
  • I have a specific, actionable, and well motivated feature request to propose.

Lotus component

  • lotus daemon - chain sync
  • lotus fvm/fevm - Lotus FVM and FEVM interactions
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt/WinningPoSt)
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

What is the motivation behind this feature request? Is your feature request related to a problem? Please describe.

FIP 0085 is prototyped and can merge in go-state-types once we merge the nv23 banch. We need to test it.

Describe the solution you'd like

Migration test in lotus asserting the new state of f090. Setup f090 with a known key and spend before migration. Demonstrate that this does not work after migration.

Describe alternatives you've considered

No response

Additional context

Just filing this so we don't forget

@ZenGround0 ZenGround0 self-assigned this Apr 18, 2024
@rjan90 rjan90 added this to the Network v23 milestone Apr 25, 2024
@rjan90 rjan90 changed the title Test fip 85 once migration integrated Test FIP-0085 once migration integrated May 3, 2024
@rjan90
Copy link
Contributor

rjan90 commented May 3, 2024

Hey! Is it okay that I move the testing plan for this FIP into this issue #11939, so its easier to see all the testing surface we have covered for FIPs targeting nv23?

@rjan90
Copy link
Contributor

rjan90 commented May 8, 2024

Completeded an E2E testing with https://github.com/filecoin-project/go-state-types/releases/tag/v0.14.0-dev5, and can confirm that f090 now throws off:

lotus msig inspect f090
ERROR: actor code is not multisig: account

I will close this ticket now, with the testing plan being moved to #11939. Only need a migration test in Lotus asserting the new state of f090 before we can 🟢 this for nv23.

@rjan90 rjan90 closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants