Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skeleton for nv23 to support development and testing #11772

Closed
Tracked by #11939
rjan90 opened this issue Mar 22, 2024 · 2 comments · Fixed by #11964
Closed
Tracked by #11939

Add skeleton for nv23 to support development and testing #11772

rjan90 opened this issue Mar 22, 2024 · 2 comments · Fixed by #11964
Assignees
Milestone

Comments

@rjan90
Copy link
Contributor

rjan90 commented Mar 22, 2024

With the development/testing and shipping of nv22 coming to an end, we need to add the skeleton for nv23 without any upgrade epochs, code / state changes / migrations. It should have no effect except on local devnets to unblock implementation work, testing and tests.

How to create this skeleton is documented in: https://github.com/filecoin-project/lotus/pull/11065/files (which we probably should merge now, and iterate on rather then it staying in a PR).

@rjan90 rjan90 added this to the Network v23 milestone Mar 22, 2024
@rjan90
Copy link
Contributor Author

rjan90 commented Apr 14, 2024

@rjan90 rjan90 self-assigned this Apr 15, 2024
@rjan90 rjan90 linked a pull request Apr 22, 2024 that will close this issue
8 tasks
@rjan90
Copy link
Contributor Author

rjan90 commented May 2, 2024

Ran the nv23 skeleton with the above mentioned PRs locally, and had a successful pre-migration, migration and network upgrade:

Pre-Migration:

manifest cid: bafy2bzacecn7uxgehrqbcs462ktl2h23u23cmduy2etqj6xrd6tkkja56fna4
2024-05-02T09:59:16.039+0200    INFO    fil-consensus   filcns/upgrades.go:2741 Started 5 workers
2024-05-02T09:59:16.040+0200    INFO    fil-consensus   filcns/upgrades.go:2741 Creating migration jobs
2024-05-02T09:59:16.040+0200    INFO    fil-consensus   filcns/upgrades.go:2741 Result writer started
2024-05-02T09:59:16.040+0200    INFO    fil-consensus   filcns/upgrades.go:2741 Done creating 17 migration jobs after 984.625µs
2024-05-02T09:59:16.040+0200    INFO    fil-consensus   filcns/upgrades.go:2741 Worker 3 done
2024-05-02T09:59:16.040+0200    INFO    fil-consensus   filcns/upgrades.go:2741 Worker 0 done
2024-05-02T09:59:16.040+0200    INFO    fil-consensus   filcns/upgrades.go:2741 Worker 4 done
2024-05-02T09:59:16.040+0200    INFO    fil-consensus   filcns/upgrades.go:2741 Worker 2 done
2024-05-02T09:59:16.040+0200    INFO    fil-consensus   filcns/upgrades.go:2741 Worker 1 done
2024-05-02T09:59:16.041+0200    INFO    fil-consensus   filcns/upgrades.go:2741 Result writer wrote 17 results to state tree after 1.200375ms
2024-05-02T09:59:16.041+0200    INFO    fil-consensus   filcns/upgrades.go:2741 All workers done after 1.194708ms
2024-05-02T09:59:16.041+0200    INFO    fil-consensus   filcns/upgrades.go:2741 All 17 done after 1.384ms (12283/s)
2024-05-02T09:59:16.041+0200    WARN    statemgr        stmgr/forks.go:263      COMPLETED pre-migration {"duration": 0.004097291}

Migration:

2024-05-02T10:07:22.090+0200    WARN    statemgr        stmgr/forks.go:202      STARTING migration      {"height": "200", "from": "bafy2bzaceczcsmczvrmkdpic43tjts65rhzlkhfx75klvnh3o5mjdscionqvq"}
manifest cid: bafy2bzacecn7uxgehrqbcs462ktl2h23u23cmduy2etqj6xrd6tkkja56fna4
2024-05-02T10:07:22.091+0200    INFO    fil-consensus   filcns/upgrades.go:2741 Started 7 workers
2024-05-02T10:07:22.091+0200    INFO    fil-consensus   filcns/upgrades.go:2741 Creating migration jobs
2024-05-02T10:07:22.091+0200    INFO    fil-consensus   filcns/upgrades.go:2741 Result writer started
2024-05-02T10:07:22.091+0200    INFO    fil-consensus   filcns/upgrades.go:2741 Done creating 17 migration jobs after 59.084µs
2024-05-02T10:07:22.091+0200    INFO    fil-consensus   filcns/upgrades.go:2741 Worker 1 done
2024-05-02T10:07:22.091+0200    INFO    fil-consensus   filcns/upgrades.go:2741 Worker 0 done
2024-05-02T10:07:22.091+0200    INFO    fil-consensus   filcns/upgrades.go:2741 Worker 3 done
2024-05-02T10:07:22.091+0200    INFO    fil-consensus   filcns/upgrades.go:2741 Worker 4 done
2024-05-02T10:07:22.091+0200    INFO    fil-consensus   filcns/upgrades.go:2741 Worker 2 done
2024-05-02T10:07:22.091+0200    INFO    fil-consensus   filcns/upgrades.go:2741 Worker 6 done
2024-05-02T10:07:22.091+0200    INFO    fil-consensus   filcns/upgrades.go:2741 Worker 5 done
2024-05-02T10:07:22.091+0200    INFO    fil-consensus   filcns/upgrades.go:2741 All workers done after 106.75µs
2024-05-02T10:07:22.091+0200    INFO    fil-consensus   filcns/upgrades.go:2741 Result writer wrote 17 results to state tree after 115.542µs
2024-05-02T10:07:22.091+0200    INFO    fil-consensus   filcns/upgrades.go:2741 All 17 done after 121.084µs (140398/s)
2024-05-02T10:07:22.091+0200    WARN    statemgr        stmgr/forks.go:211      COMPLETED migration     {"height": "200", "from": "bafy2bzaceczcsmczvrmkdpic43tjts65rhzlkhfx75klvnh3o5mjdscionqvq", "to": "bafy2bzaceczcsmczvrmkdpic43tjts65rhzlkhfx75klvnh3o5mjdscionqvq", "duration": 0.000654625}

Network version:

lotus state network-version   
Network Version: 23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant