Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit Extractor Logic #1033

Open
2 tasks
kasteph opened this issue Aug 15, 2022 · 0 comments
Open
2 tasks

Audit Extractor Logic #1033

kasteph opened this issue Aug 15, 2022 · 0 comments
Labels
help wanted Extra attention is needed P1 P1: Must be resolved

Comments

@kasteph
Copy link
Contributor

kasteph commented Aug 15, 2022 •
edited

Description

The Lily extractor logic for different tasks needs to be audited by people other than @frrist (ff. the four-eyes principle).

Acceptance criteria

  • Open a pull request with the relevant task, extractor, and Filecoin specification / reference implementation in the description, if issue found.
  • Write tests for the extractor (if none exists).

Where to begin

todo: fill out

task extractor filecoin spec / ref implementation
miner_sector_events sector_events.go#L22 fil spec, lotus ref
@kasteph kasteph added help wanted Extra attention is needed P1 P1: Must be resolved labels Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed P1 P1: Must be resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kasteph