Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TerminateSectors params extraction may interpret empty array as null #1021

Open
placer14 opened this issue Jul 6, 2022 · 0 comments
Open
Labels
kind/bug Kind: Bug P3 P3: Might be resolved

Comments

@placer14
Copy link
Contributor

placer14 commented Jul 6, 2022

Describe the bug:

We have found a case where the TerminateSectors params contained the following:

{ "Terminations": [] }

Upon extracting this w lily via parsed_messages model, it comes out like this:

{ "Terminations": null }

This breaks the consistency of that value always being an array. It should be fixed to properly extract as {"Terminations": []} in the exported data.

Example: https://filfox.info/en/message/bafy2bzaceb7ncdapqvbefefczhc63afexfeytxhtgrix7dvk4jyvurribtfk2

Lily Version: v0.11.0

@placer14 placer14 added the kind/bug Kind: Bug label Jul 6, 2022
@placer14 placer14 changed the title TerminateMessages params extraction may interpret empty array as null TerminateSector params extraction may interpret empty array as null Jul 7, 2022
@placer14 placer14 changed the title TerminateSector params extraction may interpret empty array as null TerminateSectors params extraction may interpret empty array as null Jul 7, 2022
@frrist frrist self-assigned this Aug 3, 2022
@frrist frrist removed their assignment Aug 16, 2022
@frrist frrist added the P3 P3: Might be resolved label Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Kind: Bug P3 P3: Might be resolved
Projects
None yet
Development

No branches or pull requests

2 participants