Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove async handling of terminated deals from market actor #1388

Open
alexytsu opened this issue Aug 30, 2023 · 1 comment
Open

Remove async handling of terminated deals from market actor #1388

alexytsu opened this issue Aug 30, 2023 · 1 comment
Labels
cleanup

Comments

@alexytsu
Copy link
Collaborator

This can only be done after synchronous terminations has gone live.

When that code goes live, it must still handle any deals scheduled for cleanup that haven't been processed by cron yet.

After synchronous terminations is live, it should be impossible to encounter terminated sectors asynchronously. All code paths other than on_miner_sector_terminate should not handle terminations (and error if marked-for-termination) sectors are encountered.
@alexytsu
Copy link
Collaborator Author

Must be done after #1377 goes live and after all marked-for-termination deals are cleared from chain state.

@alexytsu alexytsu mentioned this issue Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexytsu