Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health check fails on v2.28.0 #3119

Open
gowtham1337 opened this issue Apr 14, 2024 · 4 comments
Open

Health check fails on v2.28.0 #3119

gowtham1337 opened this issue Apr 14, 2024 · 4 comments

Comments

@gowtham1337
Copy link

gowtham1337 commented Apr 14, 2024

Description
The latest image (v2.28.0) of filebrowser from docker hub reports an unhealthy status even though there are no errors and the container is working as expected.

Expected behaviour
Container should report healthy

What is happening instead?
Container is reporting unhealthy

Additional context
Because the container is reporting unhealthy, errors are thrown and several other things fail. For example, a reverse proxy might think this service is unavailable and failover.

How to reproduce?
Docker compose:

filebrowser:
    image: filebrowser/filebrowser:v2.27.0 #this version works
    #image: filebrowser/filebrowser:latest - throws unhealthy check
    container_name: filebrowser
    restart: unless-stopped
    ports:
      - "81:80"
    volumes:
      - $DOCKERDIR/filebrowser/filebrowser.db:/filebrowser.db
      - $DOCKERDIR/filebrowser/.filebrowser.json:/.filebrowser.json
      - /:/srv

See that the health check for the container is reported as unhealthy in portainer. There is no difference in logs and functionality. App is working perfectly as expected but still shows unhealthy.

@ferdinandmehlan
Copy link

ferdinandmehlan commented Apr 15, 2024

There is already a fix for that: #3087
Unfortunately it's still awaiting approval.
In the mean time you could just override the host in the healthcheck:

    healthcheck:
      test: ["CMD", "curl", "-f", "http://0.0.0.0:80/health"]
      interval: 5s
      timeout: 10s
      retries: 3
      start_period: 5s

Or whatever interface your container is listening to

@yaroslav-007
Copy link

yaroslav-007 commented Apr 17, 2024

Hello,
I have put env variable "FB_ADDRESS=0.0.0.0" and seems my healthcheck was successful

@sparker81
Copy link

Any ETA on when the fix will be approved? We have 20+ filebrowser containers showing unhealthy. It's unsettling. X'D

@qdm12
Copy link
Contributor

qdm12 commented Apr 17, 2024

Since I sort of caused the bug (but fixing another bug/missing-feature), I will try to help, if you have git installed you can build it from the forked repo + bugfix branch with:

docker build -t filebrowser/filebrowser:31119-fix https://github.com/CorySanin/filebrowser.git#bugfix/healthcheck

and then use image name filebrowser/filebrowser:31119-fix for example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants