Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll lock causes iOS Safari Tab Bar to expand when opening slide-over modal #11055

Closed
zepfietje opened this issue Jan 25, 2024 · 2 comments
Closed
Assignees
Labels
Milestone

Comments

@zepfietje
Copy link
Member

zepfietje commented Jan 25, 2024

Package

filament/support

Package Version

v3.2.13

Laravel Version

10.42.0

Livewire Version

v3.4.1

PHP Version

8.3.2

Problem description

When you scroll on the page to hide the Tab Bar, and then open a slide-over modal action, the Tab Bar pops up again.

Probably caused by #10969: willmcpo/body-scroll-lock#242.

RPReplay_Final1706184125.mp4

Expected behavior

Tab Bar should stay collapsed if it was previously collapsed.

Steps to reproduce

  1. Scroll page.
  2. Open slide-over model.
  3. Watch Tab Bar pop up again.

Reproduction repository

Relevant log output

No response

@zepfietje zepfietje added bug Something isn't working unconfirmed low priority labels Jan 25, 2024
@zepfietje zepfietje self-assigned this Jan 25, 2024
@zepfietje zepfietje added the ui label Jan 25, 2024
Copy link

Hey @zepfietje! We're sorry to hear that you've hit this issue. 💛

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2024
@zepfietje zepfietje added this to the v3 milestone Jan 25, 2024
@zepfietje zepfietje changed the title Scroll lock causes iOS Safari Tab Bar to show when opening slide-over modal Scroll lock causes iOS Safari Tab Bar to expand when opening slide-over modal Jan 25, 2024
@zepfietje zepfietje reopened this Jan 25, 2024
@zepfietje
Copy link
Member Author

#10925 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

1 participant