Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmdk search keyword matching #43

Open
itsjoeoui opened this issue Apr 28, 2024 — with Linear · 1 comment
Open

Fix cmdk search keyword matching #43

itsjoeoui opened this issue Apr 28, 2024 — with Linear · 1 comment
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

Copy link
Member

itsjoeoui commented Apr 28, 2024

CleanShot 2024-04-27 at 20.37.30@2x.png

Need to update to cmdk v1 and then use the keyword field on filter: https://github.com/pacocoursey/cmdk?tab=readme-ov-file#command-cmdk-root

Make sure to fix all other components that uses cmdk, shadcn-ui/ui#2944

@itsjoeoui itsjoeoui added the bug Something isn't working label Apr 28, 2024 — with Linear
Copy link

linear bot commented Apr 28, 2024

@itsjoeoui itsjoeoui self-assigned this Apr 28, 2024
@itsjoeoui itsjoeoui added the good first issue Good for newcomers label May 2, 2024
@itsjoeoui itsjoeoui assigned SamZhang02 and unassigned itsjoeoui May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants