Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Almanac tests in uAgents #251

Open
Archento opened this issue Mar 5, 2024 · 0 comments
Open

Restructure Almanac tests in uAgents #251

Archento opened this issue Mar 5, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Archento
Copy link
Member

Archento commented Mar 5, 2024

Current situation:

  • agent_registration.py has 4 tests (2 sync, 2 async)
  • the tests in general take around 6 seconds each, most of the times ~20 seconds
  • since we apply a GitHub Actions matrix these tests will be executed 7 times on different systems/versions
  • sometimes they fail due to issues with the ledger/network or timeouts
  • these tests take a lot of time / costing a lot of money compared to the rest of the CI workflow

We should rethink how to effectively test the registration functionality as that is not completely part of the uAgents framework but rather includes or represents an interface to the Almanac.
Maybe we can mock the smart contract responses or just take these test to a separate worker.

@Archento Archento added the enhancement New feature or request label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant