Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

concat: add test coverage for error res/data #66

Closed
wants to merge 1 commit into from
Closed

concat: add test coverage for error res/data #66

wants to merge 1 commit into from

Conversation

bendrucker
Copy link
Collaborator

Adds test coverage for error cases for concat:

  • 5xx errors that return unstructured text with json: false
  • For plain and JSON error responses, assert the status code and concatenated data

Closes #65

@bendrucker bendrucker requested a review from feross May 12, 2021 17:06
@bendrucker bendrucker mentioned this pull request May 12, 2021
Open
@bendrucker
Copy link
Collaborator Author

Closing as idle, feel free to reopen and merge if interested

@bendrucker bendrucker closed this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feross feross Awaiting requested review from feross

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP 500 response not returned with Node.js 14 and concat
1 participant
@bendrucker