Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide mimeType instead of fileName #78

Open
mixmix opened this issue Mar 16, 2021 · 1 comment
Open

provide mimeType instead of fileName #78

mixmix opened this issue Mar 16, 2021 · 1 comment

Comments

@mixmix
Copy link

mixmix commented Mar 16, 2021

I have an application where I'm storing blobs and not storing the filename. I do store a: { title, mimeType, size }
At the moment I'm using render-media by faking a filename, then internally render-media guesses a mimeType from my extension. This feels slightly painful when I can see the API could be extended to just allow mimeType to be passed in directly?

Would this be a welcome addition I'm happy to open a PR.

@fix
Copy link

fix commented Mar 17, 2022

agree on this, most of the time you are able to provide with the right mime type. I think it is possible to make a simple PR that keeps backward compatibility.

That would be ok for you @feross?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants