Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for excluding files to deploy #70

Open
1 task done
joshpassenger opened this issue Nov 2, 2018 · 4 comments
Open
1 task done

Add option for excluding files to deploy #70

joshpassenger opened this issue Nov 2, 2018 · 4 comments

Comments

@joshpassenger
Copy link

This is a:

  • Feature request or change

Current behaviour

Finch deploys all files by default, including .DS_Store files

Proposed behavioir

Add option to exclude files to deploy by glob pattern

Justification

Lots of temporary files exist .gitignore, .DS_Store etc please consider an options for excluding these

@fernando-mc
Copy link
Owner

@joshpassenger sounds like a decent feature. You're welcome to open a PR that supports this and I'll review/accept. One thing I am curious about is why this shouldn't be handled by the build process itself? I imagine the .gitignore at the root of the repo which means you would be deploying a submodule in this case then?

Either way, seems like this makes sense as a general feature, thanks for the suggestion! Let me know if you're interested in implementing it, otherwise it may sit here for a while until I can find someone who has a spare moment.

@joshpassenger
Copy link
Author

Hi @fernando-mc I'll have a look at the complexity of implementing it!

It was more for dev deployments from my local machine, I have a .gitignore which would prevent these files from making it to a CICD server via git checkout.

@joshpassenger
Copy link
Author

Assign it to me?

@fernando-mc
Copy link
Owner

@joshpassenger done! Thanks for the reminder 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants