Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS MaxAgeSeconds #113

Open
1 task done
enapupe opened this issue Mar 29, 2021 · 0 comments
Open
1 task done

CORS MaxAgeSeconds #113

enapupe opened this issue Mar 29, 2021 · 0 comments

Comments

@enapupe
Copy link

enapupe commented Mar 29, 2021

  • Feature request or change

Current behavior (if any)

CORS policy sets max age to zero: https://github.com/fernando-mc/serverless-finch/blob/master/lib/resources/CORSPolicy.json#L7

Proposed behavior

Longer or customizable max-age value

Justification

Considering this tool's purpose is to upload static assets to s3, why are we setting the lifetime of the CORS preflight to zero? Why not cache it forever?
@enapupe enapupe changed the title MaxAgeSeconds CORS MaxAgeSeconds Mar 29, 2021
@mikejpeters mikejpeters mentioned this issue Mar 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@enapupe