Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spin login should store the token in the platform keystore #42

Open
gdamjan opened this issue Dec 6, 2022 · 3 comments
Open

spin login should store the token in the platform keystore #42

gdamjan opened this issue Dec 6, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@gdamjan
Copy link

gdamjan commented Dec 6, 2022

@gdamjan
Copy link
Author

gdamjan commented Dec 6, 2022

something like keyring can help I think.

ps.
I'm willing to work on this - time permitting, but I wont be mad if someone beats me to it first :)

@gdamjan
Copy link
Author

gdamjan commented Dec 6, 2022

Some notes:
service (in the keyring api) should probably be "spin.fermyon.dev"
username should be some identifier of the cloud I guess (but we can go with "default" for now)?
password will be just the token

@michelleN michelleN added the enhancement New feature or request label Dec 6, 2022
@michelleN
Copy link
Member

michelleN commented Dec 7, 2022

@gdamjan I think this would be a great addition. Would you be interested in writing a quick proposal in the form of a SIP so we can all be on the same page around design and any key decisions? Any contribution here would be much appreciated.

@gdamjan gdamjan changed the title spin login should store the token in the platofrm keystore spin login should store the token in the platform keystore Mar 12, 2023
@itowlson itowlson transferred this issue from fermyon/spin Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 📋 Investigating / Open for Comment
Development

No branches or pull requests

2 participants