Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spin deploy should rollback any changes on a CTRL+C #184

Open
bacongobbler opened this issue Oct 11, 2022 · 1 comment
Open

spin deploy should rollback any changes on a CTRL+C #184

bacongobbler opened this issue Oct 11, 2022 · 1 comment

Comments

@bacongobbler
Copy link
Member

If I cancel the spin deploy command before it finishes, the deployment can end up in an incomplete state. The bindle may be uploaded, but no application has been created.

We should figure out a way to capture that signal and roll back any changes (if possible).

@bacongobbler
Copy link
Member Author

bacongobbler commented Oct 11, 2022

One snag here will be the fact that a bindle is immutable once uploaded. There is no way to delete it from the server. And because POST /api/apps requires the bindle ID to be present on the server, we need to upload at least one bindle ID before calling that endpoint.

@itowlson itowlson transferred this issue from fermyon/spin Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Backlog
Development

No branches or pull requests

1 participant