Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where and how can I change the flash function ? #41

Closed
sucrecacao opened this issue Oct 29, 2019 · 3 comments
Closed

Where and how can I change the flash function ? #41

sucrecacao opened this issue Oct 29, 2019 · 3 comments

Comments

@sucrecacao
Copy link

Hello,
Instead of making a transparent background fading transition, I would like to have a fading border transition and/or fading white "flash".

And hint and pointers on how I could implements that ?

Thanks !

@fennerm
Copy link
Owner

fennerm commented Oct 30, 2019

This would be awesome and I'd love to help where I can but I think its probably a bit beyond my expertise. Check out #1 for some hints at how this could be achieved in X11. I think the implementation is likely to be quite different in wayland. I'd be happy to accept a PR to add this functionality for either X11 or wayland, I don't think cross-compatibility is a strict requirement.

As far as slotting this into the current codebase you would likely need to add method to the Flasher class in flashfocus.flasher and do some fiddling with the config schema.

@sucrecacao
Copy link
Author

I haven't found any function in xpybutil library that allow you to add border or a color filter on a window.
So I guess its beyond my expertise too.

But big kuddos for the source code, so neat and so clean. I was very easy to read and understand, a real pleasure !

@fennerm
Copy link
Owner

fennerm commented Nov 3, 2019

Thanks :). Closing this, feel free to reopen if you change your mind.

@fennerm fennerm closed this as completed Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants