Fix contributor link #205 #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
fennecdjay
reviewed
Oct 7, 2020
README.md
Outdated
| @@ -120,7 +120,7 @@ Thanks goes to these wonderful people ([emoji key](https://github.com/kentcdodds | |||
| <td align="center"><a href="https://github.com/nithin-pankaj"><img src="https://avatars2.githubusercontent.com/u/15152472?v=4" width="100px;" alt=""/><br /><sub><b>Nithin Pankaj</b></sub></a><br /><a href="https://github.com/fennecdjay/Gwion/commits?author=nithin-pankaj" title="Code">💻</a></td> | |||
| <td align="center"><a href="https://github.com/evayde"><img src="https://avatars1.githubusercontent.com/u/25255815?v=4" width="100px;" alt=""/><br /><sub><b>Enrico Gruner</b></sub></a><br /><a href="https://github.com/fennecdjay/Gwion/commits?author=evayde" title="Code">💻</a></td> | |||
| <td align="center"><a href="https://github.com/umer2001"><img src="https://avatars2.githubusercontent.com/u/35496058?v=4" width="100px;" alt=""/><br /><sub><b>Muhammad Umer Farooq</b></sub></a><br /><a href="https://github.com/fennecdjay/Gwion/commits?author=umer2001" title="Code">💻</a></td> | |||
| <td align="center"><a href="http://shuvalov.info"><img src="https://avatars2.githubusercontent.com/u/1410106?v=4" width="100px;" alt=""/><br /><sub><b>Shuvalov Anton</b></sub></a><br /><a href="https://github.com/fennecdjay/Gwion/commits?author=a" title="Documentation">📖</a></td> | |||
| <td align="center"><a href="http://shuvalov.info"><img src="https://avatars2.githubusercontent.com/u/1410106?v=4" width="100px;" alt=""/><br /><sub><b>Shuvalov Anton</b></sub></a><br /><a href="https://github.com/fennecdjay/Gwion/commits?author=a-mere-peasant" title="Documentation">📖</a></td> | |||
There was a problem hiding this comment.
href should be https://github.com/a-mere-peasant.
img src should be https://avatars3.githubusercontent.com/u/50142453?s=400&u=4844f21d4f48431d854307ecdf4d1f4d80977ab9&v=4
The bold text should be ... well I don't know, let's ask @a-mere-peasant
I hope the notation is clear.
|
@a-mere-peasant, what should we use as username? |
|
|
Fixed. |
|
That's nice, thanks everyone. |
|
@all-contributors please add @ry-v1 for documentation. |
|
I've put up a pull request to add @ry-v1! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix contributor link #205. Please check