Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add single header magic #114

Merged
merged 2 commits into from May 14, 2019
Merged

add single header magic #114

merged 2 commits into from May 14, 2019

Conversation

scalarwaves
Copy link
Contributor

Pertaining to #112 This header is a start for binding to other languages.

Having all core header files in one place makes importing the library version of Gwion much simpler.

Based on this gist by fennecdjay.

@fennecdjay
Copy link
Member

Nice! 🍾
I'm a bit worried with the ../ thing thought.
Can't you use something like -I../ast/include -I../util/include ?
It would save us the ../ and gain some flexibility.

@scalarwaves
Copy link
Contributor Author

Your solution is more elegant, I returned it to its original state.

@fennecdjay
Copy link
Member

fennecdjay commented May 14, 2019

Looking Good!
Is there anything you want to add for this particular PR?
If not I'll merge as soon as the test succeed (wondering why travis is not showing up).

Does it mean you had some success with codegen?


EDIT: probably got travis back.

@fennecdjay
Copy link
Member

Looks Good! Merging 🍾
Thank you @scalarwaves.

@fennecdjay fennecdjay merged commit a33c22d into Gwion:master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants