Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datanommer does not store the agent_name #1309

Closed
abompard opened this issue Apr 25, 2024 · 1 comment · Fixed by #1322
Closed

Datanommer does not store the agent_name #1309

abompard opened this issue Apr 25, 2024 · 1 comment · Fixed by #1322

Comments

@abompard
Copy link
Member

The message's agent (in the agent_name property) is not store specifically by datanommer, only as part of the usernames. It would be interesting to filter on the agent name only, see fedora-infra/fedbadges#100

@abompard
Copy link
Member Author

abompard commented Apr 25, 2024

Obviously this will require a schema change, and it will increase the DB size (data + index).
This should be a column in the messages table, because there's only one agent_name, and joins to a hypertable are expensive in timescaledb.
The extract-users command should be updated to take it into account.
The agent and not_agent arguments should be added to the Message.grep()
Also, datagrepper should be updated to add the new filters

abompard added a commit to abompard/datanommer that referenced this issue Jun 7, 2024
Fixes: fedora-infra#1309

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
abompard added a commit to abompard/datanommer that referenced this issue Jun 7, 2024
Fixes: fedora-infra#1309

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
abompard added a commit to abompard/datanommer that referenced this issue Jun 7, 2024
Fixes: fedora-infra#1309

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
abompard added a commit that referenced this issue Jun 7, 2024
Fixes: #1309

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant