Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of waivers for queued/running tests #5414

Open
AdamWill opened this issue Jul 12, 2023 · 2 comments
Open

Improve handling of waivers for queued/running tests #5414

AdamWill opened this issue Jul 12, 2023 · 2 comments

Comments

@AdamWill
Copy link
Contributor

AdamWill commented Jul 12, 2023

A post from @rwmjones on devel highlighted some issues with waivers and queued/running tests:

https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/CAGORC7P56D66CTYIQ4PT2SO4GJHGEB2/

I'll have to verify this, but I believe that as things stand, the web UI will allow you to file waivers for required tests that are queued/running, but the greenwave gating status calculation does not take such waivers into account. Obviously that's inconsistent.

Personally I think it's correct that we don't allow queued/running tests to be waived. If we go with that, then the Bodhi web UI should not offer to file waivers for queued/running tests, only failed and possibly missing ones (I'll have to check if greenwave 'accepts' waivers for missing tests).

Also, if a waiver for a queued/running test somehow exists (e.g. someone creates it directly in waiverdb), it shouldn't be considered as 'applying', i.e. we shouldn't show the thumbs-up for it on the Automated Results tab. This overlaps somewhat with #5397 .

@AdamWill
Copy link
Contributor Author

note: I found out today that waiving 'missing' results does work.

@AdamWill
Copy link
Contributor Author

AdamWill commented Sep 5, 2023

#5397 (comment) would partly address this by not showing running tests as waived even if a waiver is filed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant