Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit message to mark user activity on automatic updates? #5275

Open
mattiaverga opened this issue Apr 26, 2023 · 1 comment
Open

Emit message to mark user activity on automatic updates? #5275

mattiaverga opened this issue Apr 26, 2023 · 1 comment
Labels
Discussion Issues that may be controversial and warrant a discussion

Comments

@mattiaverga
Copy link
Contributor

When a user submits an update to any release for which automatic updates are not enabled, a message of UpdateRequestTestingV1 type is emitted on fedora message bus with an agent equal to username. This is useful for detecting that the user is active.

However, when the user make a build in Koji for a release where automatic updates are enabled, the automatic update created by Bodhi will not emit any message with an agent equal to the username. It will only emit an UpdateRequirementsMetStableV1 under bodhi agent, thus no user activity is detected.

Shall we emit an UpdateRequestTestingV1 also upon automatic update creation, so that user activity is correctly detected? Would emit such a message cause any trouble to QA tests (unexpected runs triggered, for example)? @AdamWill

Do we also want to emit a UpdateRequestStableV1 under bodhi agent as we do for manual updates?

@mattiaverga mattiaverga added the Discussion Issues that may be controversial and warrant a discussion label Apr 26, 2023
@AdamWill
Copy link
Contributor

Man, the scheduling code has gotten a bit complex over time, but reviewing it, it looks like this message - the topic is bodhi.update.request.testing , right? - sends us down a path where we only schedule the tests if they have not already been scheduled. So this shouldn't cause unwanted reruns, or anything; it should be OK.

I need to go back and look at that scheduling code and see if we can simplify it - I think with all the changes over the last year or two to what messages Bodhi emits when, we can probably drop some paths - but haven't had the roundtuits. Thanks for the heads up about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Issues that may be controversial and warrant a discussion
Projects
None yet
Development

No branches or pull requests

2 participants