-
-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swallowing Error Hook #767
Comments
Looks like here - https://github.com/feathersjs/express/blob/master/lib/rest/wrappers.js#L60 and https://github.com/feathersjs/socket-commons/blob/master/lib/utils.js#L119 are adding a |
Indeed, definitely faulty logic there. #769 should fix it and will be published shortly. |
Thanks @daffl much appreciated. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs. |
I have a hook which will set
context.result
from an error hook. This works when called by an internal server call but does not work when called by an external client request.I have created the following repo that reproduces the issue here - https://github.com/Mattchewone/feathers-buzzard-error-hooks
If you run the mocha tests in VSCode you can see that the service call sets the
context.result
and the response is correct, but with the client calls thecontext.result
is set but the request still returns the error.Not sure what
context.returnHook
does internally but this isfalse
for a server call, buttrue
for a client call.The text was updated successfully, but these errors were encountered: