Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify block placement code in chunk.rs to update heightmaps. #482

Open
Miro-Andrin opened this issue Sep 24, 2021 · 0 comments
Open

Modify block placement code in chunk.rs to update heightmaps. #482

Miro-Andrin opened this issue Sep 24, 2021 · 0 comments

Comments

@Miro-Andrin
Copy link
Contributor

Miro-Andrin commented Sep 24, 2021

This issue: #451 was determined to be caused by the server not doing any light updates correctly. To implement lighting, and solve it we would have to work on the chunk code some more. https://github.com/feather-rs/feather/blob/main/feather/base/src/chunk.rs Me and some others have looked into adding lighting, but there is one thing that looks like it might be a self contained issue.

To do efficient skylight updates it would be excellent to have assess to a up to date heightmap, but as it stands one would have to
call the recalculate height-map function before every skylight update. This is probably bad. It would be nice if the heightmap was kept up to date, when the chunk was modified, or at least a flag was set if it was potentially made out of date.

@Miro-Andrin Miro-Andrin changed the title Modify block placement code tin chunk to update heightmaps. Modify block placement code in chunk.rs to update heightmaps. Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant