Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving generated code into libcraft? #459

Open
Miro-Andrin opened this issue Sep 7, 2021 · 1 comment · May be fixed by #514
Open

Moving generated code into libcraft? #459

Miro-Andrin opened this issue Sep 7, 2021 · 1 comment · May be fixed by #514

Comments

@Miro-Andrin
Copy link
Contributor

I was looking at adding recipes to libcraft #429 , but noticed that Item and ItemStack are in feather, under the generated folder.
Any reason why we should not move all the generated code from feather to libcraft?

Description of change.

Move feather/feather/generated/* into feather/libcraft/generated
And make the generated structs repr-c such that we can use them in quill.
@koskja
Copy link
Contributor

koskja commented Sep 7, 2021

I agree, maybe we could also move the feather-generated and the dapapack crate there.

@Miro-Andrin Miro-Andrin mentioned this issue Sep 11, 2021
Merged
4 tasks
@Iaiao Iaiao linked a pull request Jan 19, 2022 that will close this issue
Draft
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to 1.18 Iaiao/feather
2 participants
@Miro-Andrin @koskja