Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issues]: Fix CommonJS dependency warnings #370

Open
deleteLater opened this issue May 18, 2023 · 10 comments
Open

[Good First Issues]: Fix CommonJS dependency warnings #370

deleteLater opened this issue May 18, 2023 · 10 comments
Assignees
Labels
angular good first issue Good for newcomers help wanted Extra attention is needed points:16

Comments

@deleteLater
Copy link
Contributor

deleteLater commented May 18, 2023

Description

When running the frontend project with npm run start, the following warnings are displayed:

image

Before attempting to resolve this issue, I would recommend first reviewing https://web.dev/commonjs-larger-bundles/.

Scope

  • Service: UI

Setup dev environment

Please read the doc to set up your development environment.

Deadline

We usually give 2 weeks for a feature request, which means you have 2 weeks to implement the feature starting from the
day it is assigned to you. If you have any difficulties, please contact us in Slack.

How to implement

  1. Fork the FeatBit repository.
  2. Create a branch issues-{issues number}
  3. Implement the task based on Description and Scope mentioned above.
  4. Submit your PR

If the feature is UI related, make sure you complete the following tasks before submit your PR:

  • merge featbit main branch into your working branch
  • run npm run i18n
  • commit messages.xlf & messages.zh.xlf file changes (if any)

Contribution points

Each contribution counts a certain number of points, depending on its difficulty. Contributors earn the appropriate
points when the work is merged. Contribution points are used to describe the contributions that contributors have made.
They can also be used to receive rewards for community events. You can view the current community submissions on a
public google sheet.

Points: 12

How to claim to solve the issue

If you want to implement this function, please leave a comment in this issue like:

I'd like to implement this function, please assign this issue to me.

@deleteLater deleteLater added good first issue Good for newcomers help wanted Extra attention is needed angular points:16 labels May 18, 2023
@defqd
Copy link
Contributor

defqd commented May 18, 2023

I'd like to implement this function, please assign this issue to me.🐱‍🐉

@cosmos-explorer
Copy link
Contributor

@defqd just assigned the issue to you, thank you

@deleteLater
Copy link
Contributor Author

Hi @defqd 👋

I recommend that you separate the solution into multiple PRs, one for each of the following:

  • lodash
  • momentjs
  • prismjs

This will make it easier for us to focus on each change individually, and it will also make it easier to merge the changes once they have been reviewed.

@deleteLater
Copy link
Contributor Author

Replace loadsh with lodash-es: #378

@yashchaddha
Copy link

I would like to work on this issue, hence would like to request for it to be assigned to me
Thanks in advance

@deleteLater
Copy link
Contributor Author

Thanks @yashchaddha, I've assigned this issue to you ☘️

@lokeshvasnik
Copy link

@yashchaddha You still working on this issue??

@deleteLater
Copy link
Contributor Author

deleteLater commented Aug 12, 2023

Hi @lokeshvasnik If you're interested, you can try to resolve this issue

@mucoban
Copy link
Contributor

mucoban commented Oct 28, 2023

hi @deleteLater, @cosmos-explorer I can remove the warnings with allowedCommonJsDependencies . You can assign me if it is ok for you.

@qixiaojian310
Copy link
Contributor

I'd like to implement this function, please assign this issue to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular good first issue Good for newcomers help wanted Extra attention is needed points:16
Projects
Status: Todo
Development

No branches or pull requests

7 participants