Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vignettes are outdated #10

Open
lrnv opened this issue Sep 25, 2023 · 0 comments
Open

Vignettes are outdated #10

lrnv opened this issue Sep 25, 2023 · 0 comments

Comments

@lrnv
Copy link

lrnv commented Sep 25, 2023

Hi,

The vignette https://cran.r-project.org/web/packages/plsRglm/vignettes/plsRglm.pdf section 3.3.1 proposes the following code :

library(plsRglm)
data(aze)
Xaze<-aze[,2:34]
yaze<-aze$y
cv.modpls<-cv.plsRglm(dataY=yaze,dataX=Xaze,nt=10,modele="pls-glm-logistic",K=8)

which prints lots of stuff (avoidable with verbose=FALSE), but then ends up on :

Error in PLS_glm_kfoldcv(dataX = Xaze, nt = 10, modele = "pls-glm-logistic",  :         
  argument "dataY" is missing, with no default

Which is coherent with ?cv.plsRglm, which explicitly states the cv.plsRglm(formula,dataX,...) syntax and not the cv.plsRglm(dataY,dataX,...) syntax, which (i guess?) is now outdated.

Last but not least, it looks like this vignette was not compiled since 2014 : maybe it should be fixed and set to recompile regularly (at least on CI) so that these issues are caught quicker ?

Happy to discuss


EDIT: I could not find the code corresponding to that vignette in this repo. It looks like pkgdown should contain a html compiled version of that vignette, but it does not, and only link to the CRAN pdf. Could you gently point me to the script ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant