New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default for window size in EquivalentSourcesGB #487
base: main
Are you sure you want to change the base?
Conversation
…such that approximately 5000 data points are in each window.
|
…aising an error. Need to raise an error for data points less than and equal to 5e3.
Completed with @santisoler |
Update test to check for data points less than 5e3 and the associated warning.
This is starting to look great @indiauppal! I'm leaving a few ideas after the meeting we had today:
This is somewhat my personal wishlist for this PR, so feel free to assign me a few of these tasks if you want. As always, feel free to ask for help if you need it 🙂 Looking forward to see this merged! |
@indiauppal, I'm updating this branch after the fix I made for the failing Mac testing. Remember to run a |
Add India Uppal to the author list.
This reverts commit 14b1f65.
Change the default for the window size in the EquivalentSourcesGB constructor. By default, approximately 5000 data points are in each window.
Relevant issues/PRs:
Fixes #425