Add a minimalistic implementation of Euler Deconvolution #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thank you for opening your first pull request in this repository! 💖 A few things to keep in mind:
⭐ No matter what, we are really grateful that you put in the effort to do this! ⭐ |
VascoSch92
reviewed
Apr 30, 2024
| The instance itself, updated with the estimated `location_` | ||
| and `base_level_`. | ||
| """ | ||
| n_data = field.shape[0] |
There was a problem hiding this comment.
Suggestion: it could be interesting to add a check for the self.location_ and self.base_level_ parameters, i.e., if they are different then None, then the class has already been fit and an error is thrown.
This prevent to fit more then once the same class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of a minimalist implementation of Euler Deconvolution, accompanied by tests for magnetic and gravimetric data. The tests also include analyses with varying base levels and derivatives calculated analytically and via FFT.
Fixes #268
Relevant issues/PRs: