Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop distributing test files? #77

Open
5 tasks
santisoler opened this issue Nov 2, 2022 · 1 comment
Open
5 tasks

Stop distributing test files? #77

santisoler opened this issue Nov 2, 2022 · 1 comment

Comments

@santisoler
Copy link
Member

santisoler commented Nov 2, 2022

Description:

Currently most of our libraries hold their test functions along with the source code. Moreover, when we distribute the code (upload to PyPI or conda-forge) we are also providing this test functions and classes, along with the test data they need. This forces each user to download a bunch of files that they are not going to ever use (see #44). Particularly Harmonica is seeing its test/data folder to growing a lot with sample grid files.

Would be better if we don't distribute the test folder inside the source code of our packages. This will lower the bandwidth and disk space required to install our packages without changing the user experience. If anyone wants to test the code, they will have to git clone the repo and run the tests, but this is how they should do so already.

Is there any reason why we would like to keep distributing those?

cc @leouieda

Apply to:

Further instructions:

  • Start by opening Pull Requests on each repository listed above.
  • Optionally, we can open Issues on each repository if further discussion specific to that repository is needed.
  • Mention this Issue on every Issue or Pull Request opened on each opened: Related to fatiando/community#77
  • Check-off the repository on the list above once the Pull Request is merged.
  • Close this issue when all items are checked-off.

We want your help!

We know that maintenance tasks are very demanding, so we don't expect a single person to tackle this issue by themselves. Any help is very welcomed, so please comment below that you want to take care of the changes on any repository and we will assign it to you.

@leouieda
Copy link
Member

leouieda commented Nov 3, 2022

Packaging the tests lets us run the tests on the installed/packaged code like this: https://github.com/conda-forge/verde-feedstock/blob/main/recipe/meta.yaml#L39

But I'm not sure how useful that turns out to be.

@santisoler santisoler changed the title Stop distributing test files Stop distributing test files? Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants