Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import xls files #889

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from
Draft

Import xls files #889

wants to merge 24 commits into from

Conversation

luilver
Copy link
Contributor

@luilver luilver commented Oct 1, 2020

Remove deprecation warnings: Fix #888

Add Import xls and xlsx files feature.

@CloCkWeRX
Copy link
Member

I'm happy to merge 1d6e840 if its fixing deprecation warnings (which ones?); but you might want to cherry pick to a specific branch rather than master.

@luilver
Copy link
Contributor Author

luilver commented Feb 20, 2021

I'm happy to merge 1d6e840 if its fixing deprecation warnings (which ones?); but you might want to cherry pick to a specific branch rather than master.

This is the deprecation warning: #888

Which branch should I cherry pick instead of master ?

@luilver luilver changed the title Remove deprecation warnings Import xls files Feb 20, 2021
@luilver luilver marked this pull request as draft February 24, 2021 12:15
@CloCkWeRX
Copy link
Member

CloCkWeRX commented May 7, 2021

@luilver Try something like

git remote add upstream git@github.com:fatfreecrm/fat_free_crm.git
git fetch upstream
git checkout upstream/master
git checkout -b fix-deprecation
git cherry-pick 1d6e840
git push origin fix-deprecation

and that should give you just that change on an isolated branch as a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warnings should be removed
3 participants