Fix for #1122 - working under WSL2, Ruby 3.0.6 #1135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrisoxide
changed the title
ferrisoxide
changed the title
fix i18n fix selenium specs
ferrisoxide
force-pushed
the
installing_under_wsl
branch
from
31adcf5
to
685adba
Compare
ferrisoxide
changed the title
|
it worked... |
|
Basically the standard for if a PR is worth it is if it's fixing a problem :) I would maybe suggest splitting upgrades vs other issues, maybe using an issue to track the big picture. But, let me take a bit of a look |
OK, I'll look at splitting these into separate PRs. K++ |
|
Closing this PR in favour of separate issue-specific PRs. See |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various small fixes to get FatFreeCRM installing under WSL using Postgres and Ruby 3.0.6
NB Updating Ruby appears necessary - at least on WSL - to get
mini_racerto install. It assumes use of the geckodriver for executing feature specs via modern Firefox.This also attempts to fix #1122
This is my first PR for FatFreeCRM, so I'm not sure if pushing an update to the Ruby version, etc is compatible with what the community is after.